This repository has been archived by the owner on Aug 21, 2018. It is now read-only.
Rewrote docker container using bioconda environment.yml #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! |
|
hah, ok cool :) The changes are all based on the docker build and the tests only use the latest dockerhub version so won't have been checking the new code. But the old code has been broken for a month or so anyway, so I guess this won't be much worse..?? |
|
Yeah, precisely |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the docker build has been failing for nearly a month: https://hub.docker.com/r/scilifelab/ngi-rnaseq/builds/
Took this as an opportunity to refactor using bioconda. Need to check that this generates containers that work offline - not entirely sure that all required R packages are installed yet.