-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some realignment stuff still left in there. Personally I think the USAGE.md docs can be improved quite a lot from a beginners perspective. But that should probably be a different PR.
docs/USAGE.md
Outdated
@@ -93,28 +93,33 @@ Choose an output directory | |||
|
|||
### --project `ProjectID` | |||
|
|||
Specify a project number ID on a UPPMAX cluster. (optionnal if not on such a cluster) | |||
Specify a project number ID on a UPPMAX cluster. | |||
(optionnal if not on such a cluster) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
docs/USE_CASES.md
Outdated
@@ -1,6 +1,9 @@ | |||
# Use cases | |||
|
|||
The workflow has three pre-processing options: `mapping`, `realign` and `recalibrate`. Using the `mapping` directive one will have a pair of mapped, deduplicated and recalibrated BAM files in the `Preprocessing/Recalibrated/` directory. Furthermore, during this process a deduplicated BAM file is created in the `Preprocessing/NonRealigned/` directory. This is the usual option you have to give when you are starting from raw FASTQ data: | |||
The workflow has three pre-processing options: `mapping`, `realign` and `recalibrate`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realign should be removed here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll update that as well
docs/USE_CASES.md
Outdated
@@ -93,7 +112,8 @@ SUBJECT_ID XX 1 SAMPLEIDR 9 /samples/relapse9_1.fastq.gz /sample | |||
|
|||
## Starting from realignement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if this paragraph and the one below should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
👍 👏 |
So now, where can we find some beginners to help us with this USAGE.md docs? |
I can give it a go. But it would need some careful proofreading for factual errors. |
PR checklist
dev
branch./scripts/test.sh -p docker -t ALL
).CHANGELOG.md
is updatedREADME.md
is updated