Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Update more Docs #637

Merged
merged 16 commits into from
Sep 10, 2018
Merged

Update more Docs #637

merged 16 commits into from
Sep 10, 2018

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Sep 10, 2018

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • CHANGELOG.md is updated
  • README.md is updated

@maxulysse maxulysse changed the title Docs Update more Docs Sep 10, 2018
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some realignment stuff still left in there. Personally I think the USAGE.md docs can be improved quite a lot from a beginners perspective. But that should probably be a different PR.

docs/USAGE.md Outdated
@@ -93,28 +93,33 @@ Choose an output directory

### --project `ProjectID`

Specify a project number ID on a UPPMAX cluster. (optionnal if not on such a cluster)
Specify a project number ID on a UPPMAX cluster.
(optionnal if not on such a cluster)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*optional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@@ -1,6 +1,9 @@
# Use cases

The workflow has three pre-processing options: `mapping`, `realign` and `recalibrate`. Using the `mapping` directive one will have a pair of mapped, deduplicated and recalibrated BAM files in the `Preprocessing/Recalibrated/` directory. Furthermore, during this process a deduplicated BAM file is created in the `Preprocessing/NonRealigned/` directory. This is the usual option you have to give when you are starting from raw FASTQ data:
The workflow has three pre-processing options: `mapping`, `realign` and `recalibrate`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realign should be removed here right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll update that as well

@@ -93,7 +112,8 @@ SUBJECT_ID XX 1 SAMPLEIDR 9 /samples/relapse9_1.fastq.gz /sample

## Starting from realignement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if this paragraph and the one below should be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@alneberg
Copy link
Member

👍 👏

@maxulysse
Copy link
Member Author

So now, where can we find some beginners to help us with this USAGE.md docs?

@alneberg
Copy link
Member

I can give it a go. But it would need some careful proofreading for factual errors.

@maxulysse maxulysse merged commit c57c348 into SciLifeLab:dev Sep 10, 2018
@maxulysse maxulysse deleted the Docs branch September 10, 2018 11:29
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants