Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Preparing new release #640

Merged
merged 12 commits into from
Sep 13, 2018
Merged

Preparing new release #640

merged 12 commits into from
Sep 13, 2018

Conversation

maxulysse
Copy link
Member

  • Adding helper script to change version number
  • Updating RELEASE_CHECKLIST

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • CHANGELOG.md is updated

@maxulysse maxulysse changed the base branch from master to dev September 12, 2018 14:46
@alneberg
Copy link
Member

Seems to be a conflict for CHANGELOG. I guess it's due to my recent PR.

.github/RELEASE_CHECKLIST.md Outdated Show resolved Hide resolved
.github/RELEASE_CHECKLIST.md Show resolved Hide resolved
- [#615](https://github.com/SciLifeLab/Sarek/pull/615) - Add presentation
- [#615](https://github.com/SciLifeLab/Sarek/pull/615) - Update documentation
- [#620](https://github.com/SciLifeLab/Sarek/pull/620) - Add `tmp/` to `.gitignore`
- [#625](https://github.com/SciLifeLab/Sarek/pull/625) - Add [`pathfindr`](https://github.com/NBISweden/pathfindr) as a submodule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're obsessed with whitespace changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just notice there was a beautifier in atom, so run it on CHANGELOG

scripts/do_release.sh Show resolved Hide resolved
@maxulysse
Copy link
Member Author

I preferred not to list this new documentation in our README, since it will mainly be used by us only.
Are you OK with that?

@alneberg
Copy link
Member

alneberg commented Sep 13, 2018 via email

@alneberg
Copy link
Member

Great job! Let's merge!

@maxulysse maxulysse merged commit 7a10f5d into SciLifeLab:dev Sep 13, 2018
@maxulysse maxulysse deleted the release branch September 13, 2018 11:24
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants