Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

input bam file has always the same name #665

Merged
merged 2 commits into from
Oct 16, 2018
Merged

input bam file has always the same name #665

merged 2 commits into from
Oct 16, 2018

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Oct 15, 2018 •
edited
Loading

  • input bam file has always the same name in the MarkDuplicates process
    before, it was called runId.bam for single pair fastq and sampleId.bam for multiple pairs fastq

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • CHANGELOG.md is updated

szilvajuhos
szilvajuhos approved these changes Oct 16, 2018
View reviewed changes
Copy link
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, weird I had not noticed before.

@szilvajuhos szilvajuhos merged commit 4ea9a43 into SciLifeLab:dev Oct 16, 2018
@maxulysse maxulysse deleted the consistency branch October 16, 2018 08:11
@maxulysse
Copy link
Member Author

I guess we never really checked the names of the metrics file from this process.
But Pontus did notice, so I figured it was an easy fix ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szilvajuhos szilvajuhos szilvajuhos approved these changes

@alneberg alneberg Awaiting requested review from alneberg

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @szilvajuhos