Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Add Tuebingen specific configuration parameters #673

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Add Tuebingen specific configuration parameters #673

merged 2 commits into from
Oct 24, 2018

Conversation

apeltzer
Copy link
Collaborator

PR checklist

  • PR is made against dev branch
  • PR is a hotfix against master branch
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

This adds configuration for Tuebingen infrastructure (BinAC cluster, CFC Cluster) and adds a more generic resource config for these resources. We can get this for others up as well, but it works quite nicely here on the servers. I also added the new publishDirMode params automatically :-)

@apeltzer
Copy link
Collaborator Author

If you#re happy, I'll config descriptions as well in the docs and update the Changelog

@maxulysse
Copy link
Member

That looks very good indeed.
I'm happy with all that.

Usually I make the PR, and then commit the CHANGELOG with [skip ci]

@apeltzer
Copy link
Collaborator Author

Can do that as well, but can't commit directly to Sarek but just send in PRs from my fork

@maxulysse
Copy link
Member

Only doing PR myself, I have the rights to make commit on the repo, but I don't

@maxulysse maxulysse merged commit 9c28a03 into SciLifeLab:dev Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants