-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
|
||
## Downloading cache | ||
|
||
An helper script has been designed to help downloading snpEff and VEP cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add here as well that this is only necessary if one is not running on uppmax and do not wish to use the specific containers.
@@ -12,6 +13,8 @@ Subsets of all containers can be downloaded: | |||
- For annotation for GRCh38, you will need: | |||
- [snpeffgrch38](#snpeffgrch38-) | |||
- [vepgrch38](#vepgrch38-) | |||
- For annotation with cache use: | |||
- [sarek](#sarek-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in that case, I could probably say, you should already have this one...
@@ -112,6 +111,23 @@ Possible values are: | |||
Choose vcf to annotate. | |||
Different vcfs to be separated by commas. | |||
|
|||
### --annotate_cache | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify the edge cases, for example: using: --annotate_cache
but not either --snpEff_cache
or --vep_cache
; using --snpEff_cache
without --annotate_cache
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't work.
You need to use --annotate_cache
with --snpEff_cache
or/and --vep_cache
If you use only --annotate_cache
it's not using cache
If you use only --snpEff_cache
or/and --vep_cache
it's not using cache either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, can you have that in the docs? It will not crash though, it will just not do what one thinks it does. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will specify all that then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Slightly to big for me to be able to grasp all the changes though. But I can't spot any errors at least.
Currently seems to be working well on |
Annotation worked well on munin, with and without the annotation cache. |
also closes #554 |
--annotation_cache
parameter to use the annotation cache, which need to be used with:---snpEff_cache
to specify snpEff cache--vep_cache
to specify VEP cachePR checklist
dev
branch./scripts/test.sh -p docker -t ALL
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedEDIT: Forgot the details...