Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Multiple patient TSV #728

Merged
merged 29 commits into from
Feb 20, 2019
Merged

Multiple patient TSV #728

merged 29 commits into from
Feb 20, 2019

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Feb 14, 2019

  • Removed cross patient somatic calls when using multiple patient TSV file
  • VCFs and Annotated VCFs are now ordered by Patient, then tools
  • Strelka Best Practices output is now prefixed with StrelkaBP_
  • Improved usage of targetBED params
  • Fix issue with annotation that was consuming cache channels

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • Documentation in docs is updated
  • CHANGELOG.md is updated

Copy link
Collaborator

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - also love the code cleanup :-)

@maxulysse
Copy link
Member Author

When we switched to GATK4 parts of code stayed untouched, so every now and then I encounter some stuff that was hidden, and it feels so good to delete all that...

@maxulysse
Copy link
Member Author

@KochTobi I think I fixed the issue.
Congrats to @alneberg to found out what was causing it.

Copy link
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@maxulysse maxulysse merged commit 6b4883c into SciLifeLab:dev Feb 20, 2019
@maxulysse maxulysse deleted the TSV branch February 20, 2019 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants