Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Update igenomes.config #751

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Update igenomes.config #751

merged 1 commit into from
Mar 12, 2019

Conversation

gongyixiao
Copy link
Contributor

Many thanks to contributing to Sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • PR is made against dev branch
  • PR is a hotfix against master branch
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/SciLifeLab/Sarek/blob/master/.github/CONTRIBUTING.md

@alneberg alneberg changed the base branch from master to dev March 8, 2019 07:33
@alneberg
Copy link
Member

alneberg commented Mar 8, 2019

Hi @gongyixiao, thanks for this! I changed the base branch to dev and will await the tests again.

@maxulysse
Copy link
Member

Typo in igenomes.config for smallGRCh37 genome.

@maxulysse maxulysse merged commit 5d3b38e into SciLifeLab:dev Mar 12, 2019
@maxulysse
Copy link
Member

Thanks @gongyixiao for spotting this typo ;-)

@gongyixiao
Copy link
Contributor Author

Actually, the bwaIndex in smallGRCh37 in the same file need to be changed from "dict" to "fasta" as well I think.

maxulysse referenced this pull request in maxulysse/nf-core_sarek Mar 13, 2019
@maxulysse
Copy link
Member

Got it, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants