Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Symbolics to 6, (keep existing compat) #1016

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Symbolics package from 5.30.1 to 5.30.1, 6.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-08-12-00-21-56-903-00340686961 branch from 3cc93f8 to 18bfcc1 Compare August 12, 2024 00:22
@isaacsas
Copy link
Member

@ChrisRackauckas is there a migration guide for what has changed / needs to be updated?

@ChrisRackauckas
Copy link
Member

If you're not using maketerm then you're fine. See JuliaSymbolics/Symbolics.jl#1196 as the update. I've pinged @0x0f0f0f for a NEWS.md. I think the only other thing that's relevant is that arguments(expr) no longer auto-sorts, so you have to use sorted_arguments for that. But I don't think that level of detail should effect any of our downstream libraries in anything other than maybe some printing or some latex output.

@isaacsas
Copy link
Member

We use arguments it seems in many places. No idea if the ordering was relied on in these uses -- most are by @TorkelE.

This use seems like it might be ordering dependent:

args = arguments(expr)

@isaacsas
Copy link
Member

In the Latex recipe I used sorted_arguments when updating recently, so that should be ok on our end.

@ChrisRackauckas
Copy link
Member

This use seems like it might be ordering dependent:

That shouldn't be changed. The sorting comes down to whether it should lexicographically sort things that are stored as unsorted, which is commutative operations (add, mul).

Project.toml Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

Awesome, success.

@ChrisRackauckas ChrisRackauckas merged commit 6d4289f into master Aug 21, 2024
5 checks passed
@ChrisRackauckas ChrisRackauckas deleted the compathelper/new_version/2024-08-12-00-21-56-903-00340686961 branch August 21, 2024 22:08
@isaacsas
Copy link
Member

Now for the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants