Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding discrete event to event doc #652

Merged
merged 3 commits into from
Jul 14, 2023
Merged

adding discrete event to event doc #652

merged 3 commits into from
Jul 14, 2023

Conversation

tstrey
Copy link
Contributor

@tstrey tstrey commented Jul 14, 2023

No description provided.

@TorkelE
Copy link
Member

TorkelE commented Jul 14, 2023

Maybe add something like this to the end?
"For a more throughout description of events (also called callbacks), please read this section"
and make "this section" a link to https://docs.sciml.ai/Catalyst/stable/catalyst_applications/advanced_simulations/#Event-handling-using-callbacks

tstrey and others added 2 commits July 14, 2023 17:00
@tstrey @isaacsas
Update docs/src/catalyst_functionality/constraint_equations.md
8c113ab 
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
@tstrey
Suggested changes: add link
91585f4
@isaacsas
Copy link
Member

Looks great! @tstrey are you done with it now? If so I’ll merge.

@isaacsas isaacsas merged commit 7f8cbeb into SciML:master Jul 14, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacsas isaacsas isaacsas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstrey @TorkelE @isaacsas