Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespacing #666

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix namespacing #666

merged 2 commits into from
Sep 1, 2023

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Sep 1, 2023

isaacsas
isaacsas approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to bump this once the MTK PR gets merged.

isaacsas
isaacsas reviewed Sep 1, 2023
View reviewed changes
Project.toml Outdated
@@ -30,7 +30,7 @@ JumpProcesses = "9.3.2"
LaTeXStrings = "1.3.0"
Latexify = "0.14, 0.15, 0.16"
MacroTools = "0.5.5"
ModelingToolkit = "8.47"
ModelingToolkit = "8.65"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 8.66?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are right.

@isaacsas
Copy link
Member

isaacsas commented Sep 1, 2023

Thanks! I'll merge and release a new version once the doc build finishes ok.

@YingboMa
Copy link
Member Author

YingboMa commented Sep 1, 2023

Great! Thanks!

@isaacsas isaacsas merged commit 42690b5 into master Sep 1, 2023
9 checks passed
@isaacsas isaacsas deleted the myb/update branch September 2, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacsas isaacsas isaacsas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YingboMa @isaacsas