Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #682

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Test cleanup #682

merged 7 commits into from
Sep 19, 2023

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Sep 19, 2023

I went through the tests, trying to see if there is anything that can be cut. Most of it is complication time, however, I found some Jump simulations across two files where I could remove some probably superfluous repeats of the simulations. It only removed like 1 minute in the end, had hoped to gain more.

While I went through stuff I removed some unnecessary statements, and only added a few missing StableRNG uses (where rand was called without StableRNG input).

Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest at some point we should probably update the jump solution tests to use examples with known solutions / solution statistics as in JumpProcesses, and compare to those. All these ones you are modifying are not such great accuracy tests.

@TorkelE TorkelE merged commit b5be944 into master Sep 19, 2023
8 of 9 checks passed
@TorkelE TorkelE deleted the test_cleanup branch June 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants