Test on 1.9 instead of 1.6 #733
Conversation
|
If everything passes feel free to merge. |
|
Oh, you also need to update Julia to 1.9 in the Project.toml. |
|
@TorkelE nonlinear solve tests are failing... |
|
Yeah, I am not sure if it is related to #728, Avik said that looked strange |
|
The error comes from the first let block in the nonlinear solve tests. If I manually run that code I get the error, but then if I rerun it everything works fine. |
|
Just running the block on my computer it is fine, and #721 passed as well. I still think it must have been something with that compact update that was added in. |
|
The only otehr alternatvie I can come up with is that StableRNGs have started generating some other rnd number, and this one somehow is problmatic. |
|
Ok, I had another chat with Avik, we now have a test that NonlinearSolve should solve stabily. |
|
Great, maybe just make the changes in this PR? Then we can merge this and hopefully get CI fixed. |
|
done, yeah, hopefully, this shoudl settle things. Should I try rebase the other PRs (that currently fail 1.6) on master afterwards? |
|
Yes, start updating your PRs as we merge stuff in. |
No description provided.