Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minus sign in ub=1e-2 and unneeded 'as' #759

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

elbert5770
Copy link
Contributor

@elbert5770 elbert5770 commented Jan 5, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@TorkelE
Copy link
Member

TorkelE commented Jan 9, 2024

Thanks for the PR. There is a couple of stuff being merged once some stuff in dependency packages are sorted out, can do this afterwards

@isaacsas
Copy link
Member

@TorkelE can we just merge this into the v14 branch so this doesn't set around? Seems like it should be good to go there?

@TorkelE
Copy link
Member

TorkelE commented Jan 30, 2024

I am ok with that. I don't think I would remove the as in the first commit, but I trust you guys when it comes to English.

Also, there seems to be no change here:
image
(but if there is no change I guess there is not problem either)

@TorkelE TorkelE changed the base branch from master to Catalyst_version_14 January 30, 2024 21:46
@TorkelE TorkelE merged commit d8cfe78 into SciML:Catalyst_version_14 Jan 30, 2024
6 checks passed
@TorkelE
Copy link
Member

TorkelE commented Jan 30, 2024

Actually, reading it through the as should be removed. I have rebased and merged into v14.

Thanks a lot for the PR @elbert5770 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants