Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source folder restructure #838

Merged
merged 16 commits into from
May 20, 2024
Merged

Source folder restructure #838

merged 16 commits into from
May 20, 2024

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented May 16, 2024

Moves around functions in the src folders:

  • Renamed "reaction_network.jl" to "dsl.jl".
  • Split the "reactionsystem.jl" and "networkapi.jl" files into 4 files (one for the Reaction struct, one for the ReactionSystem struct, one for conversion, and one for network analysis).
  • Moved some constant declarations from the "dsl.jl" file to the "Catalyst.jl" file.
  • Moved some functions from the "dsl.jl" file to the "expression_utils.jl" file.
  • In many files, reorder function order to group them more naturally.
  • Added some comments and section comments (generally very minor).

Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are still some places that functions got moved to that are after where they are called (sometimes into a different of the new sections).

src/Catalyst.jl Show resolved Hide resolved
src/latexify_recipes.jl Show resolved Hide resolved
src/expression_utils.jl Outdated Show resolved Hide resolved
src/networkapi.jl Outdated Show resolved Hide resolved
src/reaction_structure.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
src/reactionsystem_structure.jl Outdated Show resolved Hide resolved
src/reactionsystem_structure.jl Outdated Show resolved Hide resolved
src/reactionsystem_structure.jl Outdated Show resolved Hide resolved
@TorkelE TorkelE merged commit a45a1bc into master May 20, 2024
5 of 6 checks passed
@TorkelE TorkelE deleted the src_restructure branch May 20, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants