-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api doc proposed changes #862
Conversation
725af63
to
ffbe3cc
Compare
ffbe3cc
to
007e809
Compare
@@ -35,37 +35,41 @@ corresponding chemical reaction ODE models, chemical Langevin equation SDE | |||
models, and stochastic chemical kinetics jump process models. | |||
|
|||
```@example ex1 | |||
using Catalyst, DifferentialEquations, Plots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to remove all cases of DifferentialEquations
t = default_t() | ||
@parameters β γ | ||
@species S(t) I(t) R(t) | ||
|
||
rxs = [Reaction(β, [S,I], [I], [1,1], [2]) | ||
Reaction(γ, [I], [R])] | ||
@named rs = ReactionSystem(rxs, t) | ||
rs = complete(rs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completeness is now required for all systems.
jprob = JumpProblem(jumpsys, dprob, Direct()) | ||
sol = solve(jprob, SSAStepper()) | ||
jprob = JumpProblem(jumpsys, dprob, Direct(); save_positions = (false,false)) | ||
sol = solve(jprob, SSAStepper(), saveat = 2.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When going through the doc build times, the rendering of large figures was the biggest problem. When building the docs (containing only the API) locally, reducing the saveat for these stochastic simulations reduced the build time from over 250 seconds to 15 seconds.
The minimum required changes to make the API build on the new version.