-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix Symbolics related stuff #887
Conversation
Issue for the SDE thing: SciML/ModelingToolkit.jl#2754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to merge once runtests.jl is updated.
Should this be good now that MTK has been updated (modulo updating runtests here)? |
Turns out that StructuralIdentifiability is not compatible with the latest versions (although just checking the project.toml file it should be, so might be some of its dependencies which is causing it): SciML/StructuralIdentifiability.jl#326 Later today I plan to temporarily disable the SI extension and stuff so that it all passes. Then when SI is updated (which I imagine and hope will be soon), it should be a very quick thing to add it back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t this also bump MTK and Symbolics to the latest versions that have SymbolicUtils V2 support?
yes it should |
Cool, feel free to merge when you are done then. Once this is merged I will continue with some doc updates, but I want to wait until I can build with SymbolicUtils V2. |
Will merge as soon as everything has passed. |
Update, right now this one covers most stuff symbolics/equation related.
Symbolics.istree
withTermInterface.iscall
.hasnode
andreplacenode
symbolic functions (instead of_occursin
andreplace
).