Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Formating #916

Merged
merged 22 commits into from
Jun 8, 2024
Merged

[WIP] Formating #916

merged 22 commits into from
Jun 8, 2024

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Jun 7, 2024

Formates the full package using the updated formatter. The new one does not seem to do anything with longer comments. I might go in and add lines breaks to some of these while I am at it as well (I think all of these are old comments written by me, before I started to limit how far I extended my comments horizontally).

@TorkelE TorkelE changed the title Formating [WIP] Formating Jun 7, 2024
src/network_analysis.jl Show resolved Hide resolved
docs/pages.jl Outdated Show resolved Hide resolved
src/reaction.jl Outdated Show resolved Hide resolved
src/reaction.jl Show resolved Hide resolved
src/reactionsystem.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
src/reactionsystem_conversions.jl Outdated Show resolved Hide resolved
@isaacsas
Copy link
Member

isaacsas commented Jun 7, 2024

I went through and highlighted some particularly bad reformats, where it could potentially mislead on what the code is doing with the new alignments. I only checked core Catalyst files though and not any spatial stuff or extensions.

@TorkelE
Copy link
Member Author

TorkelE commented Jun 7, 2024

Thanks for going through, I will do the same for spatial and extensions.

TorkelE and others added 21 commits June 7, 2024 16:27
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
@TorkelE TorkelE merged commit bc6d339 into master Jun 8, 2024
3 of 7 checks passed
@TorkelE TorkelE deleted the formatting branch June 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants