Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off that warnings do not lead to doc failures #922

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Jun 7, 2024

No description provided.

@isaacsas isaacsas requested a review from TorkelE June 7, 2024 19:51
@isaacsas
Copy link
Member Author

isaacsas commented Jun 7, 2024

@TorkelE please confirm this is ok with you before I merge. Thanks!

@TorkelE
Copy link
Member

TorkelE commented Jun 7, 2024

yes, I agree this makes sense

@isaacsas isaacsas merged commit 1ce1aa5 into SciML:master Jun 7, 2024
1 of 4 checks passed
@isaacsas isaacsas deleted the fix_doc_warning_strictness branch June 7, 2024 19:54
@isaacsas
Copy link
Member Author

isaacsas commented Jun 7, 2024

Ok, we will now get doc test failures till all the PRs fixing the warnings get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants