[v14 - Ready] Fix deprecated method usage and unnecessary prints while tests run #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
commented
Jun 8, 2024
TorkelE
commented
Jun 8, 2024
TorkelE
commented
Jun 8, 2024
TorkelE
commented
Jun 8, 2024
TorkelE
changed the title
TorkelE
changed the title
TorkelE
changed the title
TorkelE
changed the title
isaacsas
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the test log now mostly cleaned of Symbolics stuff, I have been able to go through the other stuff in there and fix it. This PR fixes a couple of incorrect method usage (a few cases where I do
sys.fieldand notget_field(sys)). It also fixes some usage in the test files which leads to unnecessary warnings. Finally, I remove some cases where log messages are printed unnecessarily (producing unnecessary test in the test log).Edit: There are some cases that still remain, I am looking into these, but might take a while to figure out some stuff which is produced by other packages.