[v14 - Ready] Go through broken tests #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
commented
Jun 9, 2024
TorkelE
commented
Jun 9, 2024
TorkelE
commented
Jun 9, 2024
TorkelE
commented
Jun 9, 2024
|
Except for the weird case where MTK scambles jump parameter orders, this is ready. |
TorkelE
changed the title
isaacsas
reviewed
Jun 10, 2024
isaacsas
reviewed
Jun 10, 2024
isaacsas
reviewed
Jun 10, 2024
isaacsas
reviewed
Jun 10, 2024
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I go through broken tests. A few have been fixed/wasn't actually a problem. These are re-activated/now fixed here. For the broken ones I link the issue. I will also list the relevant issues here, as well as create a Catalyst issue listing them all:
SciML/ModelingToolkit.jl#1761
SciML/ModelingToolkit.jl#2612
SciML/ModelingToolkit.jl#2614
SciML/ModelingToolkit.jl#2778
SciML/ModelingToolkit.jl#2779
SciML/SciMLBase.jl#662
SciML/SciMLBase.jl#709
SciML/SciMLBase.jl#710
SciML/SciMLBase.jl#711
SciML/JumpProcesses.jl#417
SciML/SteadyStateDiffEq.jl#79
Latexify tests will be considered separately.
There are still 2 cases I need to figure out. I also need to go through and check everything and add some comments. Right now I am too exhausted to continue/think straight though, will finish tomorrow.