Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #967

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fix typos #967

merged 1 commit into from
Jul 6, 2024

Conversation

spaette
Copy link
Contributor

@spaette spaette commented Jul 5, 2024

@isaacsas

there may be other grammatical errors throughout the repo

@isaacsas
Copy link
Member

isaacsas commented Jul 5, 2024

@TorkelE please feel free to handle merging this one. (But right now tests are failing?)

@TorkelE
Copy link
Member

TorkelE commented Jul 5, 2024

Will handle this, the tests and some doc fixes larer today, hopefully it will be straightforward

@TorkelE TorkelE closed this Jul 6, 2024
@TorkelE TorkelE reopened this Jul 6, 2024
@TorkelE TorkelE merged commit bdfb0c7 into SciML:master Jul 6, 2024
7 of 9 checks passed
@spaette
Copy link
Contributor Author

spaette commented Jul 6, 2024

my mention of grammatical errors was solely based on my having noticed in the patch the following

where the author's intention may have been these conversions and all differentials will

$ sed -n '593p' /tmp/Catalyst.jl/src/reactionsystem_conversions.jl
                If you still would like to perform this conversions, please use the `all_differentials_permitted = true` option. In this case, all differential will be set to `0`. 
$ 

https://github.com/SciML/Catalyst.jl/commit/9db08185a81ed7ecdfb68346c8dfb2d1c7856d5f

writing fix
TorkelE
committed Jul 6, 2024, 4:36 PM CDT

this conversion and all differentials will

@TorkelE
Copy link
Member

TorkelE commented Jul 6, 2024

Thanks! I will update that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants