Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc tweaks for v14 #977

Merged
merged 1 commit into from
Jul 11, 2024
Merged

doc tweaks for v14 #977

merged 1 commit into from
Jul 11, 2024

Conversation

isaacsas
Copy link
Member

No description provided.

@TorkelE TorkelE self-requested a review July 10, 2024 22:19
@@ -165,19 +165,19 @@ cell_model = @reaction_network begin
kᵢ/V, Gᴾ --> G
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember what you said about these and that subscript would be much clearer. Always used superscript for phosphorylation, but might not be grounded in the literature. I was meaning to at some point go and look how it is typically written and possibly change then (but didn't want to change back and fourth, nor wait on it, hence I merged with P still as superscript. Probably no big consideration either way, but I think we hope to get to the number of users where we should care about small stuff like this as well)

@isaacsas isaacsas merged commit 0b6c7c4 into SciML:master Jul 11, 2024
5 checks passed
@isaacsas isaacsas deleted the doc_tweaks branch July 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants