Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation structure interfacing docs update #983

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Simulation structure interfacing docs update #983

merged 4 commits into from
Jul 12, 2024

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Jul 12, 2024

No description provided.

@TorkelE
Copy link
Member Author

TorkelE commented Jul 12, 2024

Not sure what to do about the setu section. It has the same issues for problems as normal indexing update, but is potentially relevant if someone wishes to simulate a problem for a very large number of conditions. Thinking of just sticking a warning there saying that one should be careful when applying it in certain situations. Not sure what more situations there is right now than eliminated conservative laws though.

isaacsas
isaacsas requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments, but then fine to merge.

docs/src/model_simulation/simulation_structure_interfacing.md Outdated Show resolved Hide resolved
docs/src/model_simulation/simulation_structure_interfacing.md Outdated Show resolved Hide resolved
TorkelE and others added 2 commits July 12, 2024 10:02
@TorkelE @isaacsas
Update docs/src/model_simulation/simulation_structure_interfacing.md
6c93d95 
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
@TorkelE @isaacsas
Update docs/src/model_simulation/simulation_structure_interfacing.md
bbed920 
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
@TorkelE TorkelE merged commit df01552 into master Jul 12, 2024
6 checks passed
@TorkelE TorkelE deleted the prob_indexing_doc_fix branch July 12, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacsas isaacsas isaacsas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TorkelE @isaacsas