Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adjoint for ChangeOfVariables #246

Merged
merged 8 commits into from
Mar 3, 2024
Merged

Fix adjoint for ChangeOfVariables #246

merged 8 commits into from
Mar 3, 2024

Conversation

lxvm
Copy link
Collaborator

@lxvm lxvm commented Mar 3, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The derivative tests did not catch that the ChangeOfVariables adjoint was incorrect because they all used lb, ub = 1, 3 for which the scaling factor (ub - lb) / 2 = 1. So, I added another test with a non-trivial scaling factor as well as an affine change of variables.

@lxvm lxvm merged commit 5033655 into SciML:master Mar 3, 2024
8 checks passed
@lxvm lxvm deleted the infstability branch March 3, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant