Proper handling for BandedMatrices #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 68.81% 68.92% +0.10%
==========================================
Files 24 26 +2
Lines 1889 1905 +16
==========================================
+ Hits 1300 1313 +13
- Misses 589 592 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
avik-pal
force-pushed
the
ap/banded
branch
2 times, most recently
from
f2330a6 to
14e2a4f
Compare
avik-pal
changed the title
|
What's going on with v1.8? Should we just version gate |
|
Seems like a weird one-off failure? The previous CIs for 1.8 did pass |
|
This is good to go on my end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being developed parallel to SciML/BoundaryValueDiffEq.jl#124. I will mark it as ready once properly tested!