Don't use AppleAccelerate on number types that are not floats #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixed the issue on my Mac. Prior to the fix I got |
Codecov Report
@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 69.92% 69.36% -0.56%
==========================================
Files 26 26
Lines 1965 1965
==========================================
- Hits 1374 1363 -11
- Misses 591 602 +11
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChrisRackauckas
approved these changes
Oct 31, 2023
|
yup this is correct thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisRackauckas I saw that this was done for MKL in #390, but it seems to be missing for AppleAccelerate. Is this the correct way to handle it?