Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type stable path to construct SimpleGMRES #450

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Type stable path to construct SimpleGMRES #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/simplegmres.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,16 @@
blocksize::Int
warm_start::Bool

function SimpleGMRES{UBD}(; restart::Bool = true, blocksize::Int = 0,

Check warning on line 40 in src/simplegmres.jl

View check run for this annotation

Codecov / codecov/patch

src/simplegmres.jl#L40 

Added line #L40 was not covered by tests
warm_start::Bool = false, memory::Int = 20) where {UBD}
UBD && @assert blocksize > 0
return new{UBD}(restart, memory, blocksize, warm_start)

Check warning on line 43 in src/simplegmres.jl

View check run for this annotation

Codecov / codecov/patch

src/simplegmres.jl#L42-L43 

Added lines #L42 - L43 were not covered by tests
end

function SimpleGMRES(; restart::Bool = true, blocksize::Int = 0,
warm_start::Bool = false, memory::Int = 20)
return new{blocksize > 0}(restart, memory, blocksize, warm_start)
return SimpleGMRES{blocksize > 0}(; restart, memory, blocksize,

Check warning on line 48 in src/simplegmres.jl

View check run for this annotation

Codecov / codecov/patch

src/simplegmres.jl#L48 

Added line #L48 was not covered by tests
warm_start)
end
end

Expand Down
Loading