Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document precs #551

Merged
merged 8 commits into from
Dec 1, 2024
Merged

Document precs #551

merged 8 commits into from
Dec 1, 2024

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Oct 21, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Googling "Callable object" leads to the right place in the julia docs
and is easier to understand
@j-fu
Copy link
Contributor Author

j-fu commented Oct 22, 2024

Still WIP, please wait for some updates before merging.

@j-fu j-fu marked this pull request as draft October 22, 2024 10:06
@j-fu j-fu marked this pull request as ready for review October 23, 2024 07:09
@j-fu j-fu mentioned this pull request Nov 4, 2024
5 tasks
@oscardssmith
Copy link
Contributor

looks good to me

@j-fu
Copy link
Contributor Author

j-fu commented Nov 28, 2024

Hi I really would like to see this released, because it describes a pattern which I can refer to. It allows to have "LinearSolve compatible preconditioners" without the need for an extension in LinearSolve or dependency in either direction. I intend to do corresponding PRs to ILUZero, IncompleteLU, AlgebraicMultigrid and the like.

@ChrisRackauckas ChrisRackauckas merged commit 9649e7e into SciML:main Dec 1, 2024
9 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants