Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicQuantities to 1, (keep existing compat) #2990

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DynamicQuantities package from ^0.11.2, 0.12, 0.13 to ^0.11.2, 0.12, 0.13, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@isaacsas isaacsas closed this Sep 1, 2024
@isaacsas isaacsas reopened this Sep 1, 2024
@isaacsas
Copy link
Member

isaacsas commented Sep 1, 2024

@ChrisRackauckas this seems compatible with DynamicQuantites 1.0 based on tests. (It was supposedly a minimal release in terms of breaking anything just to get a 1.x branch out there). See SymbolicML/DynamicQuantities.jl#147

@isaacsas
Copy link
Member

isaacsas commented Sep 1, 2024

Note the Catalyst failures are unrelated and due to some previously broken tests now actually being fixed.

@ChrisRackauckas ChrisRackauckas merged commit 425e89f into master Sep 1, 2024
23 of 24 checks passed
@ChrisRackauckas ChrisRackauckas deleted the compathelper/new_version/2024-08-27-00-21-21-222-03923623294 branch September 1, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants