Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to new remake_buffer signature #3020

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as draft September 5, 2024 11:32
@AayushSabharwal
Copy link
Member Author

This should only be merged once it has a compat bump for SII and SciMLBase. Waiting on SciMLBase release to do so

@AayushSabharwal AayushSabharwal marked this pull request as ready for review September 5, 2024 12:50
@ChrisRackauckas ChrisRackauckas merged commit 8f75e90 into SciML:master Sep 6, 2024
22 of 23 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-remake-buffer branch September 6, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants