Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix missing unwrap in build_explicit_observed_function #3040

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: fix missing unwrap in build_explicit_observed_function #3040

merged 2 commits into from
Sep 11, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Test?

@AayushSabharwal
Copy link
Member Author

Yeah working on getting a reproducible testcase without FMUs

@ChrisRackauckas ChrisRackauckas merged commit 9611e18 into SciML:master Sep 11, 2024
22 of 25 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-build-obs branch September 12, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AayushSabharwal @ChrisRackauckas