fix: propagate initializeprobpmap and update_initializeprob! to DAEFunction
#3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/daeprob-init
branch
from
e3cba50 to
fbc3a65
Compare
5 tasks
AayushSabharwal
force-pushed
the
as/daeprob-init
branch
2 times, most recently
from
47fe6f5 to
7cd1f71
Compare
| @mtkbuild sys = ODESystem( | ||
| [D(x) ~ p * y + q * t, x^3 + y^3 ~ 5], t; initialization_eqs = [p^2 + q^3 ~ 3]) | ||
|
|
||
| # FIXME: solve for du0 |
There was a problem hiding this comment.
It should always be updating du0?
There was a problem hiding this comment.
Initialization solves for du0, but we don't have an initializeprob_du0map which OrdinaryDiffEq can use to set the du0 of DAEProblem
There was a problem hiding this comment.
Then it doesn't actually initialize right?
There was a problem hiding this comment.
No, it doesn't apparently. Realized this while writing these tests. I think I have a way to fix it without breaking
ChrisRackauckas
approved these changes
Nov 27, 2024
AayushSabharwal
force-pushed
the
as/daeprob-init
branch
from
7cd1f71 to
5b702ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SciML/SciMLBase.jl#867
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.