Directly enforce algebraic condition correctness in ImplicitEuler #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this fix #2152 ? |
|
No, this is on ImplicitEuler |
Its extrapolation-based error estimator is 0 on algebraic variables, just like Rosenbrock23, so we add the algebraic condition evaluations to the equations just like Rosenbrock23
ChrisRackauckas
force-pushed
the
algebraic_conditions_ie
branch
from
cb01bf3
to
06f838e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its extrapolation-based error estimator is 0 on algebraic variables, just like Rosenbrock23, so we add the algebraic condition evaluations to the equations just like Rosenbrock23