Dispatches get_tmp on wrapper type of cache, #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes allocation issue for Base.Array, but issue remains for more complex AbstractArray types.
|
I think this is fine. I don't think it's possible to unsafe wrap without deleting the allocation of the wrapper. It might be nice to make a Julia Base issue on that (maybe talk with Shuhei, I think he'd have a solution). But returning a SubArray I think is fine. |
|
Run the formatter. |
|
Sorry, didn't know how, but it's pleasantly easy! |
ChrisRackauckas
added a commit
to SciML/SciMLSensitivity.jl
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes allocation issue for Base Array, but issue remains for more complex AbstractArray types.
Also, Base Arrays containing dual numbers now don't pass the typeof(...) tests. It seems like they are still usable and I haven't noticed performance losses in my applications, but I thought it's worth mentioning (tests highlighted with @test_broken).