CompatHelper: bump compat for SymbolicUtils to 1, (keep existing compat) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ChrisRackauckas
force-pushed
the
compathelper/new_version/2023-01-14-00-07-48-714-00114732458
branch
from
0b38b80
to
9e367f0
Compare
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 94.23% 88.47% -5.77%
==========================================
Files 6 6
Lines 295 295
==========================================
- Hits 278 261 -17
- Misses 17 34 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ChrisRackauckas : I am a bit puzzled why changing the compat reduces code coverage that much. Otherwise, I guess this can be merged. Also, I see perhaps we should no longer support/test Julia 1. What do you think? |
|
Probably better to hold off on this till ModelingToolkit and Catalyst get updated first. You'll want to bump compat to require their new versions at that point anyways. |
|
It seems that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
SymbolicUtilspackage from0.17, 0.18, 0.19to0.17, 0.18, 0.19, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.