Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more doctests #623

Merged
merged 19 commits into from
Jun 16, 2022
Merged

more doctests #623

merged 19 commits into from
Jun 16, 2022

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

ba2tro added a commit to ba2tro/DiffEqFlux.jl that referenced this pull request Jun 14, 2022
Fixed dereferencing of parameters in NeuralDSDE here for SciML/SciMLSensitivity.jl#623 to work , Lux compatible constructors for all layers have been added in SciML/pull/722
@ba2tro
Copy link
Contributor

ba2tro commented Jun 14, 2022

These would need to be changed to p = [p1,p2] to be in line with SciML/DiffEqFlux.jl/pull/724 .

@ba2tro
Copy link
Contributor

ba2tro commented Jun 15, 2022

Looks like we need Random and Flux to be added in the docs env. Also it seems to be erroring on the examples that are broken into pieces


optf = GalacticOptim.OptimizationFunction(loss_neuralode, adtype)
optprob = GalacticOptim.OptimizationProblem(optfunc, prob_neuralode.p)
optf = Optimization.OptimizationFunction(loss_neuralode, adtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
optf = Optimization.OptimizationFunction(loss_neuralode, adtype)
optf = Optimization.OptimizationFunction(loss_n_ode, adtype)

@ba2tro
Copy link
Contributor

ba2tro commented Jun 15, 2022

The pem example https://github.com/SciML/DiffEqSensitivity.jl/runs/6893742668?check_suite_focus=true#step:5:172
has issues because its running in chunks?

ChrisRackauckas and others added 6 commits June 15, 2022 17:59
Co-authored-by: Abhishek Bhatt <46929125+Abhishek-1Bhatt@users.noreply.github.com>
Co-authored-by: Abhishek Bhatt <46929125+Abhishek-1Bhatt@users.noreply.github.com>
@ChrisRackauckas ChrisRackauckas merged commit fc4ca1f into master Jun 16, 2022
@ChrisRackauckas ChrisRackauckas deleted the doctests2 branch June 16, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants