Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX: Fix for not symlinked openblas and lapack #40

Merged
merged 1 commit into from
Jan 9, 2020
Merged

OSX: Fix for not symlinked openblas and lapack #40

merged 1 commit into from
Jan 9, 2020

Conversation

Uditgulati
Copy link
Member

This fixes linking step during compilation in OSX.

@Uditgulati Uditgulati mentioned this pull request Jan 5, 2020
Open
@developerfab
Copy link

I think that we should update the README.md file saying that is necessary add these 2 libraries or specify in this file the instructions to add these libraries in OSx and Linux. I don't know if you want to add these comments or you prefer that I add a new commit adding it. WDYT? 🤔

@Uditgulati
Copy link
Member Author

Yes, I had plans for adding these instructions to README but it slipped my mind. I also am thinking of adding some other stuff to README, so I think it might be better to open a different PR for README.

Also, I think I should also add fix for windows to this PR. Maybe for other distributions of Linux than Debian too?

@Uditgulati
Copy link
Member Author

@prasunanand WDYT?

@prasunanand prasunanand merged commit 573e27d into SciRuby:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uditgulati @developerfab @prasunanand