Justin extensions #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second comparison of this method in awesome_print/formatter.rb causes
the crash.
Without this fix, pry + awesome_print cannot be used, as even a simple
case such as
[1, 2, 3].to_scale
will crash
# Catch all method to format an arbitrary object.
#------------------------------------------------------------------------------
def awesome_self(object, type)
if @options[:raw] && object.instance_variables.any?
awesome_object(object)
elsif object == ENV
awesome_hash(object.to_hash)
else
colorize(object.inspect.to_s, type)
end
end
I bumped the version to 1.4.1. * master: Updated README Fixed the implementation error of throw an error on comparing vector with another object, when only false should be sended Checking awesome_print error Updated license to BSD-3 (I could change it later). Added stable documentation Updated references Changed Manifest, dependences and README.rd Deleted bin. Added version file Updating to 1.4.0 Raising in equality precludes working with AwesomePrint Conflicts: .gitignore Gemfile Gemfile.lock lib/statsample/version.rb
This is the computation that fails def t_r(r,size) r * Math::sqrt(((size)-2).to_f / (1 - r**2)) end
|
This one too #9 |
|
Thanks for pointing that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit history