Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

November Binary Update #316

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

martindevans
Copy link
Member

Added new binaries.

 - Built by this run: https://github.com/SciSharp/LLamaSharp/actions/runs/6921572568
 - commit: `e937066420b79a757bf80e9836eb12b88420a218`
 - Rearranged paths
Copy link
Collaborator

@AsakusaRinne AsakusaRinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the nuspec files to ensure the auto-release working? The only things need to be done is to append the paths of new libraries. :)

LLama/Native/NativeApi.Load.cs Outdated Show resolved Hide resolved
@martindevans
Copy link
Member Author

martindevans commented Nov 19, 2023

@AsakusaRinne I've updated the nuspec files and I think they build correctly. I haven't really worked with nuspec much before though so please look at those closely in your review!

@AsakusaRinne
Copy link
Collaborator

It looks good, I'll double-check the nuget package generation before next release. :)

@SignalRT
Copy link
Collaborator

@martindevans It looks good, and I pass all test locally with the binaries.

Copy link
Collaborator

@SignalRT SignalRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me

@martindevans martindevans merged commit 597188c into SciSharp:master Nov 20, 2023
3 checks passed
@martindevans martindevans deleted the update_binaries_nov branch November 20, 2023 19:45
This was referenced Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants