Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use llama instead of libllama in [DllImport] #465

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

jasoncouture
Copy link
Contributor

This results in windows users not needing to rename the DLL. This allows native llama builds to be dropped in, even on windows.

I also took the time to update the documentation, removing references to renaming the files, since the names now match.

Fixes #463

This results in windows users not needing to rename the DLL. This allows native llama builds to be dropped in, even on windows.

I also took the time to update the documentation, removing references to renaming the files, since the names now match.

Fixes SciSharp#463
@martindevans
Copy link
Member

This looks like a great fix, thanks very much.

@jasoncouture
Copy link
Contributor Author

Looks like it needs a small tweak to the manual path search logic to work on OS X/Linux, I'll get that pushed soon.

@jasoncouture
Copy link
Contributor Author

jasoncouture commented Jan 30, 2024

Should be fixed in 443ce4f
image

@martindevans martindevans merged commit 0f9742c into SciSharp:master Jan 30, 2024
3 checks passed
@martindevans
Copy link
Member

Thanks!

I'll run a new build and update #460 with new binaries right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DllImport should not be prefixed with lib
2 participants