-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create nuspec for OpenCL #489
Conversation
Looks good, I'll check it again in detail once #487 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be rebased onto master and squashed into one commit, since some of the changes have been done in other PRs.
Before doing that please remove libllama.so
and llama.dll
(those binaries will be added when #479 is merged).
Also please link exactly where clblast.dll
and libclblast.so
came from, so file hashes can be verified.
clblast.dll source: "https://github.com/CNugteren/CLBlast/releases/download/1.6.0/CLBlast-1.6.0-windows-x64.7z" After some discussion on slack, we're going to yank the SO out for now, for a few reasons.
On windows, however, OpenCL is normally packaged with the graphics driver. So we can validate the dll and it should "just work". |
44ff200
to
5e24cff
Compare
Updated and squashed to a single commit. |
3078e0a
to
5a4d55b
Compare
5a4d55b
to
2fb5be4
Compare
430d781
to
c963b05
Compare
Fix SHA256 hash path
Thanks! I'll merge this and start a new compile run |
@jasoncouture looks like the run failed: https://github.com/SciSharp/LLamaSharp/actions/runs/7790112762/workflow |
Depends on #487 - Adds a NuGet package for OpenCL (CLBLAST)