Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nuspec for OpenCL #489

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

jasoncouture
Copy link
Contributor

Depends on #487 - Adds a NuGet package for OpenCL (CLBLAST)

@jasoncouture jasoncouture marked this pull request as ready for review February 5, 2024 11:50
@martindevans
Copy link
Member

Looks good, I'll check it again in detail once #487 is merged.

Copy link
Member

@martindevans martindevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be rebased onto master and squashed into one commit, since some of the changes have been done in other PRs.

Before doing that please remove libllama.so and llama.dll (those binaries will be added when #479 is merged).

Also please link exactly where clblast.dll and libclblast.so came from, so file hashes can be verified.

@jasoncouture
Copy link
Contributor Author

clblast.dll source: "https://github.com/CNugteren/CLBlast/releases/download/1.6.0/CLBlast-1.6.0-windows-x64.7z"

After some discussion on slack, we're going to yank the SO out for now, for a few reasons.

  1. It's relatively easy to install for your distro.
  2. you need opencl installed anyway, installing libclblast will pull that in for you automatically.
  3. OpenCL on linux has 3 or 4 variants, a generic version, intel, amd, nvidia. So, since that needs to be installed, may as well leave it to the user to also install libclblast as well.

On windows, however, OpenCL is normally packaged with the graphics driver. So we can validate the dll and it should "just work".

@jasoncouture
Copy link
Contributor Author

Updated and squashed to a single commit.

@jasoncouture jasoncouture force-pushed the clblast_nuget branch 2 times, most recently from 3078e0a to 5a4d55b Compare February 5, 2024 17:08
Fix SHA256 hash path
@martindevans
Copy link
Member

Thanks! I'll merge this and start a new compile run

@martindevans martindevans merged commit 0592164 into SciSharp:master Feb 5, 2024
3 checks passed
@martindevans
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants