Fix pickle/deepcopy for non-default argument CRSs #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
commented
Mar 22, 2020
| @@ -328,7 +328,7 @@ def get_proj_libraries(): | |||
| else: | |||
| extras_require[section].append(line.strip()) | |||
| install_requires = extras_require.pop('default') | |||
| tests_require = extras_require.pop('tests', []) | |||
| tests_require = extras_require.get('tests', []) | |||
There was a problem hiding this comment.
I just wanted to pip install the test dependencies with pip install -e .[tests] rather than having to do something like python setup.py test (which I'm not 100% confident actually works).
There was a problem hiding this comment.
It's a deprecated entry point now, so we shouldn't really rely on it, too.
QuLogic
approved these changes
Mar 22, 2020
|
Looks like you missed the license headers. |
|
Implementation seems reasonable enough. Not sure if we're expecting CI to fail right now. |
|
Going to ignore Python3 docs since that's fixed on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently the CRS
__reduce__implementation ignores the state entirely (i.e.__getstate__is never called), and you end up withdeepcopy/ pickle returned instances which have default values, not the values that the original instance had.Implications