Remove deprecations #1897
Merged
Remove deprecations #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 3, 2021
greglucas
force-pushed
the
remove-deprecations
branch
from
d2c4b9a
to
a4a0521
Compare
QuLogic
reviewed
Oct 7, 2021
The deprecation warnings have been around for several years now with alternatives given, so remove these from the code base.
Users can call add_feature instead. This has been deprecated for several years now. There are other tests that test the add_feature interface already, so just remove this test as it isn't really testing anything new.
It has been deprecated for several years now.
It has been deprecated for several years now.
Users should call Stamen('terrain-background') now.
Moved the references up to the new section.
These have been deprecated for several years now.
It has been deperecated for several years and has an alternative in matplotlib.
These should use Mercator.GOOGLE now instead.
greglucas
force-pushed
the
remove-deprecations
branch
from
a4a0521
to
e8b320f
Compare
QuLogic
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of deprecated code, which had alternatives and warnings associated with it.
Deprecations I've left for now: