Pyproj geodesic trace #2069
Merged
Pyproj geodesic trace #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Geod class doesn't support `geod_line` from the geodesic routines, but we can simulate that by individual forward/inverse calls.
dopplershift
approved these changes
Aug 22, 2022
|
Halfway descent: https://github.com/SciTools/cartopy/blob/main/lib/cartopy/tests/test_geodesic.py I am also in-favor of this :) and when I was playing around with wheel building, I believe geos was much easier to build than proj, so we could probably even give the wheels a shot before removing the geos dependency as well. |
|
Wheels are a great idea idea in theory, but we still have the problem of needing to make sure that at all times CartoPy is built against the same version of GEOS as Shapely. #1174 The next step is to eliminate compiling against GEOS and just rely on Shapely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @QuLogic's work in the first commit, and removes the last remaining remnants of PROJ required for installation. I removed all the mentions of the library and requirements in the second commit.
This will likely be slower (only with geodesic calculations), similar to the previous move to pyproj in v0.20, but I think it will greatly simplify the installation, making up for the loss in speed and moving us one step closer to building wheels...