FIX: gridliner auto-updates by default (and always in future) #2330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
As suggested at #1792 (comment), updating gridlines and their labels when the figure is re-drawn (or tight_bbox re-calculated) is now the default. Also deprecate the option to not update.
Closes #1792
Implications
There is one change in an image test result, where the zero labels on the equator have disappeared from the top right plot. I'm not 100% clear why this is. There is some logic that makes labels invisible based on how much space is available so my best guess is that the calculation after
tight_layout
puts us just the other side of the threshold for "not enough space", though any changes in positioning are imperceptible.I guess if anyone tells us they have a use-case where
auto_update=False
matters, we can remove the deprecation.