Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: ensure Gridliner is up-to-date for title adjustment #2393

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented May 24, 2024

Rationale

Fixes #2390. Add an extra call to _draw_gridliner within the title adjustment code but only if top or geo labels are switched on.

Implications

This caused a small shift in position in the existing image test which uses constrained layout. The RMS was only 3.9 but since this is a genuine behaviour change I think it makes sense to replace the baseline image rather than increase the tolerance.

@rcomer
Copy link
Member Author

rcomer commented May 24, 2024

Note that _draw_gridliner doesn't actually do any drawing. It just creates or updates the lines and labels. I would like to rename it to something like _update_children but don't mind whether that happens here or in a separate PR.

@greglucas greglucas merged commit 11c0c4c into SciTools:main Jun 8, 2024
25 checks passed
@rcomer rcomer deleted the gl-titles branch June 23, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoAxes._update_title_position called before Gridliner._labels is populated
2 participants