Persist calendar when discarding cftime microsecond #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
added
Type: Bug
Release: Patch
New: Pull Request
bjlittle
commented
Jun 29, 2021
Codecov Report
@@ Coverage Diff @@
## v3.0.x #183 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 7 7
Lines 833 833
Branches 105 105
=======================================
Hits 755 755
Misses 64 64
Partials 14 14
Continue to review full report at Codecov.
|
bjlittle
commented
Jun 29, 2021
bjlittle
commented
Jun 29, 2021
| @@ -62,6 +62,7 @@ exclude = ''' | |||
| | build | |||
| | dist | |||
| )/ | |||
| | _version.py | |||
There was a problem hiding this comment.
This file is auto-generated by setuptools-scm and should not be linted
There was a problem hiding this comment.
Full disclosure: I don't understand this file. But if it's auto-generated and @bjlittle is happy with it then it should be 👍
bjlittle
changed the title
rcomer
reviewed
Jun 30, 2021
rcomer
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR addresses issues discovered whilst testing SciTools/iris when attempting to unpin
cftime, whereby the specificcalendarofcftime.datetimeobjects are not persisted whenever thecf_units._discard_microsecondfunction was called.Once this PR is merged, I'd like to cut a
cf-units3.0.1 patch release to support aniris3.0.3 patch release.