Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt cython3 (require >=3) #460

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Adopt cython3 (require >=3) #460

merged 6 commits into from
Sep 20, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Sep 19, 2024

🚀 Pull Request

Description

@pp-mo pp-mo marked this pull request as draft September 19, 2024 11:56
@pp-mo pp-mo changed the title Adopt cython3 (now required) Adopt cython3 (require >=3) Sep 19, 2024
@pp-mo pp-mo marked this pull request as ready for review September 19, 2024 13:31
@pp-mo
Copy link
Member Author

pp-mo commented Sep 19, 2024

@trexfeathers I think this may possibly be all that is needed ?

So far, this adopts exactly what Bill proposed :

  • insist on Cython>=3
  • remove the "language_level" setting.

But .. I'm still not sure it wouldn't be better to simply unpin Cython, and leave the language-level explicit (which is then not superfluous).

Particularly as I see that the build does raises a warning about the default having changed recently.
/Users/runner/work/cf-units/cf-units/.tox/py311-osx-test/lib/python3.11/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /Users/runner/work/cf-units/cf-units/cf_units/_udunits2.pxd

What do you think ?

@pp-mo
Copy link
Member Author

pp-mo commented Sep 19, 2024

Updated to enable macos-14 (hopefully 🤞 )

@pp-mo
Copy link
Member Author

pp-mo commented Sep 19, 2024

Updated to enable macos-14 (hopefully 🤞 )

Initial attempt got a failure from setuptools-scm, which failed to identify the version.
On closer inspection of the log, it seems to be a github access timeout.

But it fails again on retry. Can't easily work out whether it is essentially a timeout, or maybe a timeout due to something else failing.

@pp-mo pp-mo linked an issue Sep 20, 2024 that may be closed by this pull request
@pp-mo
Copy link
Member Author

pp-mo commented Sep 20, 2024

Updated again to pick up the git-path fix (i.e. #464)
Hopefully that gives a solid pass (where before it seemed variable with lots of re-spins)

pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@trexfeathers trexfeathers merged commit 539dbcc into SciTools:main Sep 20, 2024
11 checks passed
@pp-mo pp-mo mentioned this pull request Sep 23, 2024
stephenworsley added a commit to rcomer/cf-units that referenced this pull request Sep 24, 2024
* main:
  [pre-commit.ci] pre-commit autoupdate (SciTools#425)
  Adopt cython3 (require >=3) (SciTools#460)
  Add repo-review (SciTools#456)
  Fully support Python 3.12 (SciTools#461)
  Bump peter-evans/create-pull-request from 6.0.4 to 7.0.5 (SciTools#459)
  Fix for bad git path in GHA macos instances. (SciTools#464)
  test macos wheels (SciTools#458)
  Bump pypa/cibuildwheel from 2.20.0 to 2.21.1 (SciTools#457)
  Fixes for CI wheels (SciTools#455)
  Dependabot check weekly. (SciTools#439)

# Conflicts:
#	.pre-commit-config.yaml
#	cf_units/tests/test_coding_standards.py
#	pyproject.toml
@pp-mo pp-mo deleted the cython3 branch September 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Cython v3
2 participants