Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-tests env generation, align with ci-locks. #481

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Sep 24, 2024

Adopting the changes which appeared to be necessary for the ci-locks action in #470 :
Do the same to ci-tests.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (792ba1e) to head (d23a0ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files           6        6           
  Lines         811      811           
  Branches       93       93           
=======================================
  Hits          734      734           
  Misses         64       64           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member Author

pp-mo commented Oct 30, 2024

Ping @trexfeathers @bjlittle can we accept this now ?

Big 🥕 it also stops using conda-main !

@pp-mo pp-mo marked this pull request as ready for review October 30, 2024 18:25
@bjlittle bjlittle merged commit 578fcdf into SciTools:main Oct 30, 2024
14 checks passed
@pp-mo
Copy link
Member Author

pp-mo commented Oct 31, 2024

Thanks @bjlittle !

@pp-mo pp-mo deleted the tidy_gha_conda branch October 31, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants